Greptile Summary

This PR replaces brittle grep|sed JSON parsing in critical shell scripts with a robust shared library (bin/lib/json-common.sh) that provides jq fast-path with python3 fallback.

Key improvements:

• Handles malformed JSON, missing keys, and whitespace variations correctly
• Returns explicit error codes (0=found, 1=missing key, 2=parsing error)
• Backward compatible behavior with existing scripts
• Comprehensive test coverage in bin/lib/json-common.test.sh

Files updated:

• bin/baudbot - version parsing
• bin/deploy.sh - release metadata reading
• bin/update-release.sh, bin/rollback-release.sh - deployment verification
• bin/security-audit.sh - version display

Security context: This hardens parsing in security-critical deployment and audit scripts, reducing risk from malformed metadata files.

Confidence Score: 5/5

• Safe to merge with minimal risk - hardens JSON parsing across critical infrastructure scripts
• The changes replace fragile regex-based parsing with proper JSON parsing libraries, include comprehensive tests, maintain backward compatibility, and are purely defensive improvements. The one minor inefficiency in bin/baudbot (4 cat calls) is a style concern, not a correctness issue.
• No files require special attention - all changes follow consistent patterns and are well-tested

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Shell Script Needs JSON Value] --> B{jq available?}
    B -->|Yes| C[jq -er with filter]
    B -->|No| D{python3 available?}
    D -->|Yes| E[Python json.load]
    D -->|No| F[Return Error Code 2]
    
    C --> G{Parse Success?}
    E --> G
    
    G -->|Value Found & String| H[Return 0 + Print Value]
    G -->|Key Missing/Wrong Type| I[Return 1]
    G -->|JSON/File Error| F
    
    H --> J[Scripts Use Value]
    I --> K[Scripts Handle Missing Key]
    F --> L[Scripts Handle Parse Error]
    
    style H fill:#90EE90
    style I fill:#FFD700
    style F fill:#FFB6C6

_{Last reviewed commit: ebcbf49}